feat(install): follow redirects for urls with no path #17449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes absolute urls, that contain no path like
deno install https://my-cli.io
to follow redirects and extract the name from it.It allows modifies
test_util
server listener on port4550
(REDIRECT_ABSOLUTE_PORT
) to allow for specifyingredirect_to
query param, that fill use that value for it's next redirect.Note: it uses
tokio::Runtime::block_on
asHttpClient
methods are all async, but I didn’t want to translate whole pipeline into async, due to the fact that the case I’m solving here is rather rare one.Fixes #17409