feat(cli): support configuring the test tool in the config file #15079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to use the config file to configure the included and excluded patterns of the test subcommand.
It has many use cases, one of them is for example when the project uses dnt to transform the tests to work on Node.js, and place them in a directory called `out/`. The test tool should not look for test files in that directory, and instead of providing the CLI args to exclude that directory everytime, the user can just have a config file like the following:
```jsonc
{
"test": {
"files": {
"exclude": ["./out/"]
}
}
}
```
This is just a single example, there might be more examples that will define the usefulness of the existence of this feature.
|
Related: #14263 |
dsherret
reviewed
Jul 12, 2022
|
@dsherret Mind another review? |
|
We've discussed this PR at the last CLI design meeting and we're in agreement this is useful. |
dsherret
approved these changes
Jul 15, 2022
dsherret
requested changes
Jul 15, 2022
dsherret
reviewed
Jul 15, 2022
|
@dsherret I added the include test. The last failed CI is not related to my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to use the config file to configure the included and excluded patterns of the test subcommand.
It has many use cases, one of them is for example when the project uses dnt to transform the tests to work on Node.js, and place them in a directory called
out/. The test tool should not look for test files in that directory, and instead of providing the CLI args to exclude that directory everytime, the user can just have a config file like the following:This is just a single example, there might be more examples that will define the usefulness of the existence of this feature.
deno testto deno.jsonc #14263