Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext/ffi): support alias names for symbol definitions #13090

Merged
merged 4 commits into from
Jan 11, 2022
Merged

feat(ext/ffi): support alias names for symbol definitions #13090

merged 4 commits into from
Jan 11, 2022

Conversation

DjDeveloperr
Copy link
Contributor

fix #13089

ry
ry reviewed Dec 15, 2021
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable change to me. BTW your sqlite project is very cool!

@DjDeveloperr DjDeveloperr mentioned this pull request Jan 10, 2022
Closed
@DjDeveloperr DjDeveloperr force-pushed the ffi-alias-symbol-name branch from 80bed10 to e5d5498 Compare January 10, 2022 14:45
@DjDeveloperr DjDeveloperr force-pushed the ffi-alias-symbol-name branch from e5d5498 to 159dc6b Compare January 10, 2022 14:54
@bartlomieju
Copy link
Member

@DjDeveloperr please rebase

bartlomieju
bartlomieju approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to me too!

@bartlomieju bartlomieju merged commit 5680d33 into denoland:main Jan 11, 2022
@DjDeveloperr DjDeveloperr deleted the ffi-alias-symbol-name branch January 11, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

@piscisaureus piscisaureus piscisaureus approved these changes

@crowlKats crowlKats Awaiting requested review from crowlKats

@kitsonk kitsonk Awaiting requested review from kitsonk

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

@littledivy littledivy Awaiting requested review from littledivy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ext/ffi: support alias names for symbol definitions
5 participants
@DjDeveloperr @bartlomieju @ry @piscisaureus @littledivy