-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] feat(ext/fetch): Implement EventSource #12350
Conversation
if you have any constructive feedback. Feel free to comment 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typings are missings, loading in 99_main
missing, don't use private properties but symbols.
Also dont see any need for the webidl dict being a variable and then assigned to the converter, could just inline that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments:
- This needs to be changed to use primordials. No globals should be used.
- This should not depend on the
fetch
function. Insteadop_fetch*
ops should be used directly, or the event source parsing should be moved to Rust (i.e.op_eventsource
+op_eventsource_next
).
I think I'll go the op fetch route. I don't really see the need to do this stuff in rust. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
This is quite a messy PR. So I've talked with @crowlKats and decided that I'm gonna implement this from scratch rather than trying to fix this PR. I will open that hopefully today or tomorrow |
closes #10298
This still needs some work.