Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"node:performance" is missing "markResourceTiming" API #19065

Closed
bartlomieju opened this issue May 9, 2023 · 1 comment
Closed

"node:performance" is missing "markResourceTiming" API #19065

bartlomieju opened this issue May 9, 2023 · 1 comment
Assignees
@bartlomieju
Labels
bug Something isn't working correctly node compat

Comments

@bartlomieju
Copy link
Member

https://twitter.com/JLarky/status/1655659098489393152
@bartlomieju bartlomieju self-assigned this May 9, 2023
@bartlomieju bartlomieju added bug Something isn't working correctly node compat labels May 9, 2023
@bartlomieju bartlomieju changed the title "node:performance" is missing "markResourceTiming API "node:performance" is missing "markResourceTiming" API May 13, 2023
@bartlomieju bartlomieju mentioned this issue May 13, 2023
Merged
bartlomieju added a commit that referenced this issue May 16, 2023
@bartlomieju
fix(npm): add performance.markResourceTiming sham (#19123)
78fbc3f 
This commit shams "performance.markResourceTiming" API by
using a noop function. It is done to provide compatibility with
"npm:undici" package. We should look into actually implementing
this API properly, but I wanted to unblock support for "undici" and
"astro" for now.

Ref #19065
@bartlomieju
Copy link
Member Author

I'm gonna close this issue for now. The API is now available, though it's a noop.

levex pushed a commit that referenced this issue May 18, 2023
@bartlomieju @levex
fix(npm): add performance.markResourceTiming sham (#19123)
e89f08d 
This commit shams "performance.markResourceTiming" API by
using a noop function. It is done to provide compatibility with
"npm:undici" package. We should look into actually implementing
this API properly, but I wanted to unblock support for "undici" and
"astro" for now.

Ref #19065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartlomieju bartlomieju

Labels
bug Something isn't working correctly node compat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartlomieju