Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node - add ClientRequest#setNoDelay #18316

Closed
dsherret opened this issue Sep 13, 2022 · 2 comments · Fixed by #21694
Closed

Node - add ClientRequest#setNoDelay #18316

dsherret opened this issue Sep 13, 2022 · 2 comments · Fixed by #21694
Assignees
Labels
bug Something isn't working correctly node compat

Comments

@dsherret
Copy link
Member

We're missing this: https://nodejs.org/api/http.html#requestsetnodelaynodelay

https://github.com/denoland/deno_std/blob/main/node/http.ts

Seems like we're missing a few methods on there actually.

Related #17852

@dsherret dsherret added bug Something isn't working correctly needs triage labels Sep 13, 2022
@kt3k kt3k transferred this issue from denoland/std Mar 21, 2023
@Joel-PeakMetrics
Copy link

Hello,

I'm seeing this failure as well using the OpenSearch client on Deno.

Error streaming agents: TypeError: request.setNoDelay is not a function

@nathanpuri
Copy link

nathanpuri commented Dec 18, 2023

I'm see this error when attempting to use PubNub (latest version), which uses superagent:

TypeError: req.setNoDelay is not a function
    at Request.request (file:///deno-dir/npm/registry.npmjs.org/superagent/8.1.2/lib/node/index.js:767:7)
    at Request.end (file:///deno-dir/npm/registry.npmjs.org/superagent/8.1.2/lib/node/index.js:919:8)
    at default_1.xdr (file:///deno-dir/npm/registry.npmjs.org/pubnub/7.4.5/lib/networking/modules/web-node.js:108:8)
    at default_1.get (file:///deno-dir/npm/registry.npmjs.org/pubnub/7.4.5/lib/networking/modules/web-node.js:200:16)
    at default_1.GET (file:///deno-dir/npm/registry.npmjs.org/pubnub/7.4.5/lib/networking/index.js:64:30)
    at class_1.default_1 (file:///deno-dir/npm/registry.npmjs.org/pubnub/7.4.5/lib/core/components/endpoint.js:273:35)
    ...

This is caused by simple this.pubnub.publish(...) call.

Are there any workarounds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly node compat
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants