feat(task): add warning about package.json scripts support (#17900)

denoland · Feb 23, 2023 · 214bdbb · 214bdbb
1 parent 998aeff
commit 214bdbb
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 0 deletions.
diff --git a/cli/tests/testdata/task/both/package_json_selected.out b/cli/tests/testdata/task/both/package_json_selected.out
@@ -1,5 +1,7 @@
 Download http://localhost:4545/npm/registry/@denotest/bin
 Download http://localhost:4545/npm/registry/@denotest/bin/1.0.0.tgz
+Warning Currently only basic package.json `scripts` are supported.
+Programs like `rimraf` or `cross-env` will not work correctly. This will be fixed in the upcoming release.
 Task bin cli-esm testing this out "asdf"
 testing
 this

diff --git a/cli/tests/testdata/task/npx/non_existent.out b/cli/tests/testdata/task/npx/non_existent.out
@@ -1,2 +1,4 @@
+Warning Currently only basic package.json `scripts` are supported.
+Programs like `rimraf` or `cross-env` will not work correctly. This will be fixed in the upcoming release.
 Task non-existent npx this-command-should-not-exist-for-you
 npx: could not resolve command 'this-command-should-not-exist-for-you'
diff --git a/cli/tests/testdata/task/npx/on_own.out b/cli/tests/testdata/task/npx/on_own.out
@@ -1,2 +1,4 @@
+Warning Currently only basic package.json `scripts` are supported.
+Programs like `rimraf` or `cross-env` will not work correctly. This will be fixed in the upcoming release.
 Task on-own npx
 npx: missing command
diff --git a/cli/tests/testdata/task/package_json/bin.out b/cli/tests/testdata/task/package_json/bin.out
@@ -1,6 +1,8 @@
 Download http://localhost:4545/npm/registry/@denotest/bin
 Download http://localhost:4545/npm/registry/@denotest/bin/0.5.0.tgz
 Download http://localhost:4545/npm/registry/@denotest/bin/1.0.0.tgz
+Warning Currently only basic package.json `scripts` are supported.
+Programs like `rimraf` or `cross-env` will not work correctly. This will be fixed in the upcoming release.
 Task bin @denotest/bin hi && cli-esm testing this out && npx cli-cjs test "extra"
 hi
 testing

diff --git a/cli/tools/task.rs b/cli/tools/task.rs
@@ -71,6 +71,11 @@ pub async fn execute_script(
         .to_owned(),
     };
     let script = get_script_with_args(script, &ps);
+    log::info!(
+      "{} Currently only basic package.json `scripts` are supported.",
+      colors::yellow("Warning"),
+    );
+    log::info!("{}", colors::gray("Programs like `rimraf` or `cross-env` will not work correctly. This will be fixed in the upcoming release."));
     output_task(task_name, &script);
     let seq_list = deno_task_shell::parser::parse(&script)
       .with_context(|| format!("Error parsing script '{task_name}'."))?;