Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023-11-17 #45

Merged
merged 5 commits into from
Nov 23, 2023
Merged

2023-11-17 #45

merged 5 commits into from
Nov 23, 2023

Conversation

windchime-yk
Copy link
Member

No description provided.

@windchime-yk windchime-yk marked this pull request as ready for review November 19, 2023 13:19
Copy link
Member Author

@windchime-yk windchime-yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kt3k @uki00a
夜分遅くに失礼します!
第24回のレポートを作成したので、レビューをお願いいたしますー!

当日、通信環境が悪かったのか入り直したりしたので、抜け漏れや誤記載あるかと思います。
不明点はコメントで記載させていただきました。よろしくお願いします。

docs/report/24.md Outdated Show resolved Hide resolved
docs/report/24.md Outdated Show resolved Hide resolved
docs/report/24.md Outdated Show resolved Hide resolved
@windchime-yk windchime-yk requested review from kt3k and uki00a November 19, 2023 13:20
Copy link
Member

@uki00a uki00a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

まとめありがとうございます!!

細かな箇所で数点だけコメントしたため、お時間ある際に確認いただけますでしょうか 🙏

docs/report/24.md Outdated Show resolved Hide resolved
docs/report/24.md Outdated Show resolved Hide resolved
docs/report/24.md Outdated Show resolved Hide resolved
docs/report/24.md Outdated Show resolved Hide resolved
docs/report/24.md Outdated Show resolved Hide resolved
docs/report/24.md Outdated Show resolved Hide resolved
kt3k

This comment was marked as duplicate.

docs/report/24.md Outdated Show resolved Hide resolved
docs/report/24.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Yuki Tanaka <uki00a@gmail.com>
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
@windchime-yk
Copy link
Member Author

@kt3k @uki00a
レビューありがとうございました!
修正しましたので、再度のレビューをお願い致します! 🙇

@windchime-yk windchime-yk requested review from uki00a and kt3k November 22, 2023 15:06
Copy link
Member

@uki00a uki00a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! ありがとうございます!

docs/report/24.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@windchime-yk
Copy link
Member Author

レビューありがとうございました! 誤字修正もありがとうございます! 🙇
マージさせていただきますー!

@windchime-yk windchime-yk merged commit 495d024 into main Nov 23, 2023
@windchime-yk windchime-yk deleted the add-report-24 branch November 23, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants