Merge pull request #1 from denisfrm/find-filter-can-handle-none-values

Fix bool filter type to handle None values
denisfrm · Jan 8, 2025 · c5fce86 · c5fce86
2 parents 1d16980 + 3d33869
commit c5fce86
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/jsonpath_ng/ext/filter.py b/jsonpath_ng/ext/filter.py
@@ -104,16 +104,11 @@ def find(self, datum):
         found = []
         for data in datum:
             value = data.value
-            if isinstance(self.value, int):
+            if type(self.value) is int:
                 try:
                     value = int(value)
                 except ValueError:
                     continue
-            elif isinstance(self.value, bool):
-                try:
-                    value = bool(value)
-                except ValueError:
-                    continue
 
             if OPERATOR_MAP[self.op](value, self.value):
                 found.append(data)

diff --git a/tests/test_jsonpath_rw_ext.py b/tests/test_jsonpath_rw_ext.py
@@ -484,6 +484,19 @@
         ["green"],
         id="boolean-filter-string-true-string-literal",
     ),
+    pytest.param(
+        "foo[?flag = true].color",
+        {
+            "foo": [
+                {"color": "blue", "flag": True},
+                {"color": "green", "flag": 2},
+                {"color": "red", "flag": "hi"},
+                {"color": "gray", "flag": None},
+            ]
+        },
+        ["blue"],
+        id="boolean-filter-with-null",
+    ),
 )