Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send attention during login #682

Merged
merged 5 commits into from
Jul 27, 2021

Conversation

shueybubbles
Copy link
Contributor

I saw test failures per issue #679 due to higher latency connections to my servers. The error should have been DeadlineExceeded but it was getting a spurious did not get cancellation confirmation.

The fix is to instruct the reader not to send attention during ctx->done() handling during the login processing.
Along the way I fixed the set language test that was failing on my server, which has a case sensitive collation.

@shueybubbles
Copy link
Contributor Author

looks like I need to learn git version kungfu :-)

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #682 (81b8118) into master (9e2f833) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   70.25%   70.39%   +0.14%     
==========================================
  Files          23       23              
  Lines        5174     5179       +5     
==========================================
+ Hits         3635     3646      +11     
+ Misses       1310     1306       -4     
+ Partials      229      227       -2     
Impacted Files Coverage Δ
tds.go 66.05% <100.00%> (+0.82%) ⬆️
token.go 61.41% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e2f833...81b8118. Read the comment docs.

@kardianos kardianos merged commit 2771b89 into denisenkom:master Jul 27, 2021
@shueybubbles shueybubbles deleted the shueybubbles-testing branch July 30, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants