Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw test failures per issue #679 due to higher latency connections to my servers. The error should have been
DeadlineExceeded
but it was getting a spuriousdid not get cancellation confirmation
.The fix is to instruct the reader not to send attention during
ctx->done()
handling during the login processing.Along the way I fixed the set language test that was failing on my server, which has a case sensitive collation.