Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

final StableBTreeMap tests #1475

Merged
merged 2 commits into from
Dec 8, 2023
Merged

final StableBTreeMap tests #1475

merged 2 commits into from
Dec 8, 2023

Conversation

lastmjs
Copy link
Member

@lastmjs lastmjs commented Dec 7, 2023

No description provided.

@lastmjs lastmjs marked this pull request as ready for review December 7, 2023 23:16
dansteren
dansteren suggested changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@dansteren dansteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 things I can see. We're getting down to a fine polish and this is all subjective so you can decide if these are worth doing or not.

property_tests/tests/stable_b_tree_map/test/contains_key.ts Show resolved Hide resolved
property_tests/tests/stable_b_tree_map/test/test.ts Show resolved Hide resolved
@lastmjs lastmjs merged commit 8272114 into main Dec 8, 2023
@lastmjs lastmjs deleted the multiple_deploy_tests branch February 10, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansteren dansteren dansteren requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lastmjs @dansteren