deps: bump sp1 to v4.0.0

[distractedm1nd]

self explanatory

Summary by CodeRabbit

Release Notes

• Dependencies

  • Updated SP1 dependencies to version 4.0.0
  • Updated secp256k1 to version 0.29.1
  • Added new patch references for curve25519-dalek-ng and ecdsa-core

• Prover Client

  • Introduced a new builder pattern for ProverClient configuration
  • Replaced ProverClient with CpuProver in the prover implementation

• Infrastructure

  • Refined dependency management and patching strategy
  • Improved client instantiation flexibility

[coderabbitai]

Walkthrough

This pull request focuses on updating dependencies and modifying the prover client implementation across multiple files. The changes primarily involve version upgrades for SP1-related dependencies in the Cargo.toml file, transitioning from branch-based to tag-based patch references. In the code, there's a shift to a builder pattern for ProverClient instantiation and a type change from ProverClient to CpuProver in the Prover struct.

Changes

File	Change Summary
Cargo.toml	- Updated SP1 dependencies (sp1-zkvm, sp1-sdk, sp1-verifier) from 3.2.1 to 4.0.0 - Updated secp256k1 from 0.29.0 to 0.29.1 - Replaced branch-based patches with tagged versions - Added new patch references for curve25519-dalek-ng and ecdsa-core
crates/cli/src/main.rs	- Replaced ProverClient::mock() with ProverClient::builder().mock().build()
crates/node_types/prover/src/prover/mod.rs	- Changed prover_client type from Arc<RwLock<ProverClient>> to Arc<RwLock<CpuProver>> - Updated prover client instantiation to use builder pattern
crates/tests/src/lib.rs	- Updated import for Prover - Replaced ProverClient::mock() with ProverClient::builder().mock().build()

Sequence Diagram

sequenceDiagram
    participant Main as Main Application
    participant ProverBuilder as ProverClient Builder
    participant Prover as CpuProver
    
    Main->>ProverBuilder: builder()
    ProverBuilder->>ProverBuilder: mock() or cpu()
    ProverBuilder->>Prover: build()
    Prover-->>Main: Configured Prover Client

Loading

Possibly related PRs

• feat: replace ed25519-dalek with ed25519-consensus #138: Updates to ed25519-consensus dependency in Cargo.toml
• refactor(prism-bin): extracting tests #139: Version updates for sp1-zkvm and sp1-sdk dependencies
• refactor(common): use underlying VK types instead of Vec<u8> #150: Updates to secp256k1 dependency

Suggested reviewers

• smuu

Poem

🐰 Hop, hop, dependencies dance!
Versions leap with each new chance
Builder pattern takes the stage
Prover client turns a new page
Cargo.toml, our config delight 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4a1e14 and 0594201.

📒 Files selected for processing (1)

• crates/tests/src/lib.rs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: unused dependencies
• GitHub Check: clippy
• GitHub Check: unit-test
• GitHub Check: integration-test
• GitHub Check: build-and-push-image

🔇 Additional comments (2)

crates/tests/src/lib.rs (2)

17-17: LGTM! Import change aligns with builder pattern usage.

The addition of Prover as _ import is correct as it's needed for the trait's methods with the new builder pattern.

---

39-39: LGTM! Correctly updated to use the new builder pattern.

The ProverClient instantiation has been properly updated to use the builder pattern introduced in sp1 v4.0.0.

Let's verify that all ProverClient instantiations have been updated consistently:

✅ Verification successful

Verification successful: All ProverClient instantiations use the new builder pattern

All instances of ProverClient in the codebase have been properly updated to use the builder pattern, including both mock and non-mock (CPU) configurations.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for any remaining direct ProverClient::mock() calls that need to be updated
# Expected: No direct mock() calls should remain

# Search for direct mock() calls
echo "Checking for direct mock() calls that need updating..."
rg "ProverClient::mock\(\)" --type rust

# Search for updated builder pattern usage
echo "Verifying builder pattern usage..."
rg "ProverClient::builder\(\)\.mock\(\)\.build\(\)" --type rust

Length of output: 592

---

Script:

#!/bin/bash
# Search for any other ProverClient instantiations to ensure complete coverage
echo "Checking for any other ProverClient instantiations..."
rg "ProverClient::" --type rust -A 2

Length of output: 983

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[smuu]

LGTM 👍