Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(prism-keys): Rename VerifyingKey to PublicKey #195

Open
Tracked by #220
distractedm1nd opened this issue Jan 8, 2025 · 1 comment
Open
Tracked by #220

improvement(prism-keys): Rename VerifyingKey to PublicKey #195

distractedm1nd opened this issue Jan 8, 2025 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@distractedm1nd
Copy link
Contributor

It was called VerifyingKey likely due to ed25519_consensus calling their key VerificationKey, which predates our key crate. This causes a ton of confusion because we also have the concept of a VerifyingKey for a ZK proof

@distractedm1nd distractedm1nd added enhancement New feature or request good first issue Good for newcomers labels Jan 8, 2025
@varun-doshi
Copy link

varun-doshi commented Jan 11, 2025

I can take this

Just to clarify, you mean this one:

pub enum VerifyingKey {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants