Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

fix windows make package and prepare 1.75.3 #543

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Mar 3, 2022

upgrade node-gyp: maybe this fixes the windows problem, though we should look at its changelog to make sure we're not affected by breaking changes

Update:
it fixes the issue and I did not see any breaking changes in node-gyp's changelog

@Simon-Laux Simon-Laux changed the title try upgrading node gyp fix windows make package and prepare 1.75.3 Mar 4, 2022
@Simon-Laux
Copy link
Member Author

Simon-Laux commented Mar 4, 2022

works on windows now, though the linux integration test crashes:

ignoring careless call to dc_accounts_event_emitter_unref()
    ✓ new message and Message methods
    ✓ Contact methods
    ✓ create contacts from address book
    ✓ delete contacts
free(): invalid pointer
Aborted (core dumped)
Error: Process completed with exit code 134.

locally on MacOS it works

@Simon-Laux
Copy link
Member Author

ok looks like it works now in the ci too, I'll take that

@Jikstra Jikstra merged commit 7b1a3b3 into master Mar 4, 2022
@Simon-Laux Simon-Laux deleted the try-upgrading-node-gyp branch March 4, 2022 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants