Fix react warning in about dialog (#2428)

deltachat · Nov 28, 2021 · 5f4f5d8 · 5f4f5d8
1 parent dba2945
commit 5f4f5d8
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -31,6 +31,7 @@
 - Fix messagelist not being at the correct position after fetching more messages
 - Fix group names/contact names & contact email addresses not being selectable
 - Fix scanning QRCode again while the Dialog is still open
+- Fix react warning in about dialog (#2428)
 
 ### Changed
 - use strict typescript for ui code

diff --git a/src/renderer/components/dialogs/About.tsx b/src/renderer/components/dialogs/About.tsx
@@ -61,22 +61,30 @@ export default function About(props: { isOpen: boolean; onClose: () => void }) {
   const desktopString = reactStringReplace(
     tx('about_offical_app_desktop'),
     'Delta Chat',
-    () => (
-      <ClickableLink href='https://delta.chat'>{'Delta Chat'}</ClickableLink>
+    (_match, _index, offset) => (
+      <ClickableLink key={offset} href='https://delta.chat'>
+        {'Delta Chat'}
+      </ClickableLink>
     )
   )
   let versionString = reactStringReplace(
     tx('about_licensed_under_desktop'),
     'GNU GPL version 3',
-    () => (
-      <ClickableLink href={gitHubLicenseUrl}>
+    (_match, _index, offset) => (
+      <ClickableLink key={offset} href={gitHubLicenseUrl}>
         {'GNU GPL version 3'}
       </ClickableLink>
     )
   )
-  versionString = reactStringReplace(versionString, 'GitHub', () => (
-    <ClickableLink href={gitHubUrl}>{'GitHub'}</ClickableLink>
-  ))
+  versionString = reactStringReplace(
+    versionString,
+    'GitHub',
+    (_match, _index, offset) => (
+      <ClickableLink key={offset} href={gitHubUrl}>
+        {'GitHub'}
+      </ClickableLink>
+    )
+  )
 
   return (
     <DeltaDialog