ref: More logging for ongoing and get_backup #4289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a few log items for imex::transfer::get_backup and the ongoing process to give some more insights. IO is now also paused after the ongoing process is allocated in get_backup to avoid needlessly pausing IO.
|
Could I have a review please? |
link2xt
reviewed
Apr 4, 2023
| @@ -260,7 +260,7 @@ enum RunningState { | |||
| Running { cancel_sender: Sender<()> }, | |||
|
|
|||
| /// Cancel signal has been sent, waiting for ongoing process to be freed. | |||
| ShallStop, | |||
| ShallStop { request: Instant }, | |||
There was a problem hiding this comment.
I think it is better to use SystemTime here, because we are interested in a wall clock time. Instant pauses on Android when the app goes to doze.
There was a problem hiding this comment.
Tough if the app goes to doze does it still execute? I want to know how long it takes to get here in application time, not in wall clock time.
There was a problem hiding this comment.
There is an issue: rust-lang/rust#71860
This is not doing what is expected, this clock is good for comparing timestamps in a build system but not for measuring time.
link2xt
approved these changes
Apr 4, 2023
d81f003 to
e95ada1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few log items for imex::transfer::get_backup and the
ongoing process to give some more insights.
IO is now also paused after the ongoing process is allocated in
get_backup to avoid needlessly pausing IO.
Notice this is targetting
stable-1.112, feel free to disagree with that.#skip-changelog