remove unneeded string duplication and fix memory leak #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ralphtheninja can you run this through the node/desktop tests and try it out, just want to be sure there are no surprises |
|
@dignifiedquire Works fine! What happened on AppVeyor there though? |
|
Unrelated, there was a brief period where the |
jptyrkko
pushed a commit
to open-xchange/deltachat-core-rust
that referenced
this pull request
Aug 19, 2019
This update addresses the tickets deltachat#133 and deltachat#134. The mode of the program is now controlled by a new configuration parameter ChatMode, whose value "off" forces the program to use the "Gr." legacy prefix, and "on", which outputs the "chat$group." prefix. For reading the header both prefixes are recognized and accepted. Function dc_create_outgoing_rfc724_mid has now a new parameter "context" to allow reading the configuration within the function. The new convention has been reflected on the tests at the end of dc_tools.rs. In the source the modified code sections are marked by the date and the committer name "Juha-Petri Tyrkkö".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think the
$crate::dc_tools::dc_strdup()is not needed for passing strings to the ffi-callback function. the ffi-callback function must treat these strings are beingconstand must not notfree()them. if the ffi-callbacks need the strings longer (eg. for queing), they must do a copy.not totally sure, however,
to_ptr()should do the job here as the return value is probably valid as long as the cstring-object exists - and this is a bit longer as the call to the ffi-callback function.