Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Configure scalafmt. Currently, this applies only to Kernel. #4160

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

scottsand-db
Copy link
Collaborator

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (BUILD)

Description

Configure scalafmt. This applies only to Kernel. Scalafmt checks passing is a requirement for Kernel compilation.

  • check if formatting is correct: build/sbt scalafmtCheckAll
  • fix formatting: build/sbt scalafmtAll

How was this patch tested?

Existing CICD

Does this PR introduce any user-facing changes?

No.

Copy link
Collaborator

@huan233usc huan233usc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Scott!

Copy link
Collaborator

@allisonport-db allisonport-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I thought a big reason to add this was for import order and I don't see any changes for that?

@allisonport-db
Copy link
Collaborator

Maybe we can add import order in a follow up PR? But I'm not sure if that might require different fmt files for different projects?

@scottsand-db scottsand-db merged commit 66d8099 into delta-io:master Feb 19, 2025
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants