Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kernel]Add simple crc post commit for incremental crc writing. #4134
[Kernel]Add simple crc post commit for incremental crc writing. #4134
Changes from 14 commits
1c05213
ca06a90
3caed70
3b7dc2c
2f58dfa
e7f4beb
52bda11
d1626dc
2a1092d
6c8069f
471e172
8c3c33b
5d0b5a7
6796fa5
2a93c49
826f623
ebaf2c8
000a36d
0c425be
e972c31
73df627
1df8af5
a3ba086
ee72c53
c8cf5b1
d922524
d2fc815
d1504f0
78477d1
7f7e9e7
bbd9ea3
76a5c38
b723b7d
f85c845
97f36fc
56b2e7e
a06bf98
1e7828b
4cddb67
dc4c94c
bf6613b
6b81868
daa03fd
0ac1005
63f2f46
622d28d
13bb0a7
972109a
c52c58e
bba00bd
93b9aeb
a11badd
cf33624
a6189d7
26cd8b8
c0178ec
cff4b84
658f770
6c70ba5
abc2bd9
305997e
e7710cb
0bec898
d392927
f60b9c6
c4ae5e5
a6be52b
eb1bca1
941d9c8
a14d42e
c4462a7
744beaf
562cfe4
b639110
5a34d7e
b9b4aac
7900389
a2e2883
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay I find these docs super clear!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add simple to method name? or some other reference that this is only if previous crc is avail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: superfluous comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: if you define
PROTOCOL
then you might as well use it here, eh?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, my bad, I forgot to update them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still
requireNoneNull
hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static fields should come before member fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some validations to make sure we are not writing some incorrect values (e.g. numMetadata is not 1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add validations, make sure to add tests for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could also instead add this validation as part of the
CRCInfo
constructor?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just have
toRow
onCRCInfo
? I think that's a better spot for this than inside ofChecksumWriter
. i.e. lower coupling, higher cohesion