[Kernel] Add Snapshot::getTimestamp public API
#3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
commented
Oct 22, 2024
| // Internal APIs // | ||
| /////////////////// | ||
|
|
||
| public Path getLogPath() { |
There was a problem hiding this comment.
- put all getters at the top of internal APIs, with more complicated internal APIs below
- re-ordered these getters to match the order of member field declarations
ebyhr
reviewed
Oct 24, 2024
| public Metadata getMetadata() { | ||
| return metadata; | ||
| /////////////////// | ||
| // Internal APIs // |
There was a problem hiding this comment.
This comment seems misleading. Even if this line says "Internal", 3rd party developers may call the subsequent method as they are public.
kernel/kernel-api/src/main/java/io/delta/kernel/internal/SnapshotImpl.java
Outdated
Show resolved
Hide resolved
20fe147 to
6f6883c
Compare
1cffcea to
5ac4bc2
Compare
kernel/kernel-api/src/main/java/io/delta/kernel/internal/SnapshotImpl.java
Outdated
Show resolved
Hide resolved
allisonport-db
approved these changes
Dec 4, 2024
vkorukanti
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Add a new
Snapshot::getTimestamppublic API.How was this patch tested?
N/A. Trivial.
Does this PR introduce any user-facing changes?
Yes. Adds a new
Snapshot::getTimestamppublic API.