[Kernel][Expressions] Add support for LIKE expression #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishnan Paranji Ravi <krishna.pr@gmail.com>
Signed-off-by: Krishnan Paranji Ravi <krishna.pr@gmail.com>
Signed-off-by: Krishnan Paranji Ravi <krishna.pr@gmail.com>
|
@vkorukanti this is ready for review. |
vkorukanti
requested changes
May 20, 2024
kernel/kernel-api/src/main/java/io/delta/kernel/expressions/Like.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
...st/scala/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluatorSuite.scala
Outdated
Show resolved
Hide resolved
created special eval for Like expression Signed-off-by: Krishnan Paranji Ravi <krishna.pr@gmail.com>
Signed-off-by: Krishnan Paranji Ravi <krishna.pr@gmail.com>
vkorukanti
requested changes
May 21, 2024
kernel/kernel-defaults/src/main/java/io/delta/kernel/defaults/internal/DefaultEngineErrors.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
...lts/src/main/java/io/delta/kernel/defaults/internal/expressions/LikeExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
...st/scala/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluatorSuite.scala
Outdated
Show resolved
Hide resolved
...st/scala/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluatorSuite.scala
Outdated
Show resolved
Hide resolved
...st/scala/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluatorSuite.scala
Show resolved
Hide resolved
...st/scala/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluatorSuite.scala
Show resolved
Hide resolved
vkorukanti
reviewed
May 21, 2024
...lts/src/main/java/io/delta/kernel/defaults/internal/expressions/LikeExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Krishnan Paranji Ravi <krishna.pr@gmail.com>
Signed-off-by: Krishnan Paranji Ravi <krishna.pr@gmail.com>
Signed-off-by: Krishnan Paranji Ravi <krishna.pr@gmail.com>
vkorukanti
requested changes
May 22, 2024
There was a problem hiding this comment.
@krishnanravi LGTM. Very close to merging. Just one comment about the empty batch handling and few more test cases. Once those done, then this PR is good to merge.
.../src/main/java/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
...lts/src/main/java/io/delta/kernel/defaults/internal/expressions/LikeExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
...lts/src/main/java/io/delta/kernel/defaults/internal/expressions/LikeExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
...lts/src/main/java/io/delta/kernel/defaults/internal/expressions/LikeExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
...st/scala/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluatorSuite.scala
Show resolved
Hide resolved
...st/scala/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluatorSuite.scala
Outdated
Show resolved
Hide resolved
...st/scala/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluatorSuite.scala
Outdated
Show resolved
Hide resolved
...lts/src/main/java/io/delta/kernel/defaults/internal/expressions/LikeExpressionEvaluator.java
Show resolved
Hide resolved
...st/scala/io/delta/kernel/defaults/internal/expressions/DefaultExpressionEvaluatorSuite.scala
Show resolved
Hide resolved
Signed-off-by: Krishnan Paranji Ravi <krishna.pr@gmail.com>
Signed-off-by: Krishnan Paranji Ravi <krishna.pr@gmail.com>
vkorukanti
approved these changes
May 23, 2024
longvu-db
pushed a commit
to longvu-db/delta
that referenced
this pull request
May 28, 2024
## Description Add SQL `LIKE` expression support in Kernel list of supported expressions and a default implementation. Addresses part of delta-io#2539 (where `STARTS_WITH` as `LIKE 'str%'`) ## How was this patch tested? added unit tests Signed-off-by: Krishnan Paranji Ravi <krishna.pr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Add SQL
LIKEexpression support in Kernel list of supported expressions and a default implementation.Addresses part of #2539 (where
STARTS_WITHasLIKE 'str%')How was this patch tested?
added unit tests