Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Protocol] Accept the Vacuum Protocol Check RFC proposal #2808

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

sumeet-db
Copy link
Collaborator

@sumeet-db sumeet-db commented Mar 26, 2024

Protocol Change Request

Description

Adds the VacuumProtocolCheck PROTOCOL change. Design Doc:
https://docs.google.com/document/d/15o8WO2T0vN21S5JG-FT_ZNhXFCWyh0i9tqhr9kBmZpE/edit#heading=h.4cz970y1mk93

closes #2630

Willingness to contribute

The Delta Lake Community encourages protocol innovations. Would you or
another member of your organization be willing to contribute this
feature to the Delta Lake code base?

  • Yes. I can contribute.
  • Yes. I would be willing to contribute with guidance from the Delta
    Lake community.
  • No. I cannot contribute at this time.

Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumeet-db sumeet-db requested a review from tdas March 27, 2024 15:52
@sumeet-db sumeet-db requested a review from tdas April 1, 2024 22:14
@sumeet-db sumeet-db requested a review from tdas April 2, 2024 17:51
| Date proposed | Date accepted | RFC file | Github issue | RFC title |
|:-|:-|:-|:-|:-|
|...|||||
| Date proposed | Date accepted | RFC file | Github issue | RFC title |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these whitespaces necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@sumeet-db sumeet-db requested a review from tdas April 3, 2024 00:27
@tdas tdas merged commit 5fdbbb6 into delta-io:master Apr 3, 2024
7 checks passed
andreaschat-db pushed a commit to andreaschat-db/delta that referenced this pull request Apr 16, 2024
## Protocol Change Request

### Description

Adds the VacuumProtocolCheck PROTOCOL change. Design Doc:

https://docs.google.com/document/d/15o8WO2T0vN21S5JG-FT_ZNhXFCWyh0i9tqhr9kBmZpE/edit#heading=h.4cz970y1mk93

closes delta-io#2630

### Willingness to contribute

The Delta Lake Community encourages protocol innovations. Would you or
another member of your organization be willing to contribute this
feature to the Delta Lake code base?

- [x] Yes. I can contribute.
- [ ] Yes. I would be willing to contribute with guidance from the Delta
Lake community.
- [ ] No. I cannot contribute at this time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PROTOCOL RFC] Enforce Vacuum Writer Protocol Check
5 participants