[Delta Protocol] Follow up comments for ClusteringTable feature #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabao521
commented
Nov 15, 2023
| - A clustering implementation is free to add additional information such as adding a new user-controlled metadata domain to keep track of its metadata. | ||
| - Writers must not define clustered and partitioned table at the same time. |
There was a problem hiding this comment.
FYI @ryan-johnson-databricks / @imback82 , this is the new rule to disallow partitioned table . This is to address comment and comment
| } | ||
| } | ||
| ``` | ||
| The example above converts `configuration` field into JSON format, including escaping characters. Here's how it looks in plain JSON for better understanding. |
There was a problem hiding this comment.
FYI @ryan-johnson-databricks , this is to address your comment https://github.com/delta-io/delta/pull/2264/files#r1393336240
dabao521
commented
Nov 15, 2023
PROTOCOL.md
Outdated
| @@ -1057,27 +1059,48 @@ When Row Tracking is enabled (when the table property `delta.enableRowTracking` | |||
|
|
|||
| The Clustered Table feature facilitates the physical clustering of rows that share similar values on a predefined set of clustering columns. | |||
| This enhances query performance when selective filters are applied to these clustering columns through data skipping. | |||
| Clustering columns must be specified during the initial definition of a clustered table, and they can be modified after the table has been created. | |||
| Clustering columns can be sprecified when creating a table or later, as long as the table doesn't have partition columns. | |||
There was a problem hiding this comment.
FYI @imback82 / @ryan-johnson-databricks , I have updated here and below to let clustering table feature to be enabled either during table creation or at a later stage . This is to address comment.
imback82
reviewed
Nov 15, 2023
imback82
reviewed
Nov 16, 2023
scottsand-db
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Follow up comments for ClusteringTable feature #2264
We had late comments after the original PR merged, and this PR is addressing those missed comments.
How was this patch tested?
N/A
Does this PR introduce any user-facing changes?
No