-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Delta Protocol] Follow up comments for ClusteringTable feature #2294
[Delta Protocol] Follow up comments for ClusteringTable feature #2294
Conversation
- A clustering implementation is free to add additional information such as adding a new user-controlled metadata domain to keep track of its metadata. | ||
- Writers must not define clustered and partitioned table at the same time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @ryan-johnson-databricks / @imback82 , this is the new rule to disallow partitioned table . This is to address comment and comment
} | ||
} | ||
``` | ||
The example above converts `configuration` field into JSON format, including escaping characters. Here's how it looks in plain JSON for better understanding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @ryan-johnson-databricks , this is to address your comment https://github.com/delta-io/delta/pull/2264/files#r1393336240
PROTOCOL.md
Outdated
@@ -1057,27 +1059,48 @@ When Row Tracking is enabled (when the table property `delta.enableRowTracking` | |||
|
|||
The Clustered Table feature facilitates the physical clustering of rows that share similar values on a predefined set of clustering columns. | |||
This enhances query performance when selective filters are applied to these clustering columns through data skipping. | |||
Clustering columns must be specified during the initial definition of a clustered table, and they can be modified after the table has been created. | |||
Clustering columns can be sprecified when creating a table or later, as long as the table doesn't have partition columns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @imback82 / @ryan-johnson-databricks , I have updated here and below to let clustering table feature to be enabled either during table creation or at a later stage . This is to address comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which Delta project/connector is this regarding?
Description
Follow up comments for ClusteringTable feature #2264
We had late comments after the original PR merged, and this PR is addressing those missed comments.
How was this patch tested?
N/A
Does this PR introduce any user-facing changes?
No