Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python): set streaming opt-in #3178

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(python): set streaming opt-in #3178

wants to merge 2 commits into from
+34 −127

Conversation

ion-elgreco
Copy link
Collaborator

@github-actions github-actions bot added the binding/python Issues for the Python package label Feb 2, 2025
@ion-elgreco ion-elgreco changed the title chore: set streaming opt-in chore(python): set streaming opt-in Feb 2, 2025
@ion-elgreco ion-elgreco enabled auto-merge February 2, 2025 12:33
@codecov Codecov
Copy link

codecov bot commented Feb 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.22%. Comparing base (9dc8f32) to head (24b3f8f).

Files with missing lines Patch % Lines
python/src/merge.rs 0.00% 3 Missing ⚠️
python/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3178   +/-   ##
=======================================
  Coverage   72.21%   72.22%           
=======================================
  Files         138      138           
  Lines       45252    45252           
  Branches    45252    45252           
=======================================
+ Hits        32678    32682    +4     
+ Misses      10504    10503    -1     
+ Partials     2070     2067    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco ion-elgreco force-pushed the chore--opt-in-streaming branch from 68597e1 to 10dedad Compare February 3, 2025 06:27
@ion-elgreco ion-elgreco requested review from rtyler and hntd187 February 3, 2025 06:28
@ion-elgreco ion-elgreco force-pushed the chore--opt-in-streaming branch from 10dedad to 4edcc09 Compare February 3, 2025 12:20
@ion-elgreco
chore: set streaming opt-in
7329b93 
Signed-off-by: Ion Koutsouris <15728914+ion-elgreco@users.noreply.github.com>
@ion-elgreco
chore: rename param
24b3f8f 
Signed-off-by: Ion Koutsouris <15728914+ion-elgreco@users.noreply.github.com>
@ion-elgreco ion-elgreco force-pushed the chore--opt-in-streaming branch from 71bcd8f to 24b3f8f Compare February 3, 2025 16:56
@ion-elgreco
Copy link
Collaborator Author

@rtyler I've renamed it to streamed_exec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjones127 wjones127 Awaiting requested review from wjones127 wjones127 is a code owner

@fvaleye fvaleye Awaiting requested review from fvaleye fvaleye is a code owner

@roeap roeap Awaiting requested review from roeap roeap is a code owner

@rtyler rtyler Awaiting requested review from rtyler

@hntd187 hntd187 Awaiting requested review from hntd187

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
binding/python Issues for the Python package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make streaming opt-in
1 participant
@ion-elgreco