change default features to be none #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
==========================================
- Coverage 74.89% 74.87% -0.03%
==========================================
Files 43 43
Lines 8409 8409
Branches 8409 8409
==========================================
- Hits 6298 6296 -2
- Misses 1724 1726 +2
Partials 387 387 ☔ View full report in Codecov by Sentry. |
hntd187
requested changes
Sep 17, 2024
nicklan
approved these changes
Sep 17, 2024
hntd187
approved these changes
Oct 1, 2024
nicklan
requested changes
Oct 1, 2024
6ab16ec to
783199c
Compare
nicklan
approved these changes
Oct 1, 2024
nicklan
pushed a commit
to nicklan/delta-kernel-rs
that referenced
this pull request
Oct 2, 2024
remove sync-engine from default features so there are no features enabled by default.
nicklan
added a commit
to nicklan/delta-kernel-rs
that referenced
this pull request
Oct 2, 2024
This reverts commit 57bf817.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove sync-engine from default features so there are no features enabled by default. note this will required delta-rs to change their dependency specification to likely turn on
arrow-conversionfeature flag.