Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses warning messages like the following:
I executed all the scripts and do not see any warning messages or any new compilation issues.
sudo ./estat.py backend-io 1
WARNING: kprobe: blk_start_request - not found
10/31/20 - 16:45:35 UTC
Tracing enabled... Hit Ctrl-C to end.
microseconds write
value range count ------------- Distribution -------------
[700, 800) 1 |@
[900, 1000) 1 |@
[1000, 2000) 4 |@@@@@@@@@@@@@@@@@@
[3000, 4000) 1 |@
write 7 1509 1007773 100
total 7 100
sudo ./estat.py iscsi 1
10/31/20 - 16:45:38 UTC
Tracing enabled... Hit Ctrl-C to end.
sudo ./estat.py metaslab-alloc 1
10/31/20 - 16:45:41 UTC
Tracing enabled... Hit Ctrl-C to end.
microseconds /dev/disk/by-id, success
value range count ------------- Distribution -------------
[0, 10) 101 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[10, 20) 8 |@@@
[20, 30) 1 |@
/dev/disk/by-id, success 110 3 15 1087
total 110 1087
sudo ./estat.py nfs 1
10/31/20 - 16:45:46 UTC
Tracing enabled... Hit Ctrl-C to end.
sudo ./estat.py nfs-by-client 1
10/31/20 - 16:45:52 UTC
Tracing enabled... Hit Ctrl-C to end.
sudo ./estat.py zio 1
10/31/20 - 16:45:55 UTC
Tracing enabled... Hit Ctrl-C to end.
microseconds write, syncw
value range count ------------- Distribution -------------
[700, 800) 1 |@
[1000, 2000) 5 |@@@@@@@@@@@@@@@@@@@@@@@@@@@
write, syncw 6 1223 72851 80
total 6 80
sudo ./estat.py zio-queue 1
10/31/20 - 16:45:58 UTC
Tracing enabled... Hit Ctrl-C to end.
microseconds write, syncw
value range count ------------- Distribution -------------
[0, 10) 6 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
write, syncw 6 4 1 72
total 6 72
sudo ./estat.py zpl 1
In file included from /virtual/main.c:63:
/usr/src/zfs-5.4.0-48-generic/include/sys/zvol_impl.h:52:2: error: unknown type name 'dataset_kstats_t'
dataset_kstats_t zv_kstat; /* zvol kstats */
^
1 error generated.
Traceback (most recent call last):
File "./estat.py", line 402, in
b = BPF(text=bpf_text, cflags=cflags, debug=debug_level)
File "/usr/lib/python3/dist-packages/bcc/init.py", line 349, in init
raise Exception("Failed to compile BPF module %s" % (src_file or ""))
Exception: Failed to compile BPF module
sudo ./estat.py zil
Tracing enabled... Hit Ctrl-C to end.
^C10/31/20 - 16:47:01 UTC
sudo ./estat.py txg
date txg time since last sync
| | | sync time
| | | | (%% pass 1)
| | | | | highest dirty (%%)
| | | | | | highest throttle delay
| | | | | | | | avg delay
v v v v v v v v v
Sat Oct 31 16:47:09 2020 49572 0ms 31ms (94 pass 1) 10MB ( 1) 0us 0ms 0ms
^Csudo ./estat.py arc_prefetch
10/31/20 - 16:47:18 UTC
^C10/31/20 - 16:47:20 UTC
sudo ./stbtrace.py io
{"t":"1604162843", "op":"write", "device":"sdb", "error":"0", "count":"1", "avgLatency":"2581745", "throughput":"12288", "latency":"{3000000,1}", "size":"{16383,1}"}
{"t":"1604162844", "op":"write", "device":"sdb", "error":"0", "count":"1", "avgLatency":"1154328", "throughput":"12288", "latency":"{2000000,1}", "size":"{16383,1}"}
{"t":"1604162844", "op":"write", "device":"sdc", "error":"0", "count":"1", "avgLatency":"1151306", "throughput":"12288", "latency":"{2000000,1}", "size":"{16383,1}"}
{"t":"1604162844", "op":"write", "device":"sdd", "error":"0", "count":"2", "avgLatency":"1182776", "throughput":"32768", "latency":"{2000000,2}", "size":"{16383,1},{32767,1}"}
{"t":"1604162844", "op":"write", "device":"sdb", "error":"0", "count":"1", "avgLatency":"1355694", "throughput":"12288", "latency":"{2000000,1}", "size":"{16383,1}"}
{"t":"1604162844", "op":"write", "device":"sdc", "error":"0", "count":"1", "avgLatency":"813503", "throughput":"12288", "latency":"{900000,1}", "size":"{16383,1}"}
{"t":"1604162845", "op":"read", "device":"", "error":"0", "count":"1", "avgLatency":"136719", "throughput":"8", "latency":"{200000,1}", "size":"{15,1}"}
{"t":"1604162845", "op":"write", "device":"sdb", "error":"0", "count":"1", "avgLatency":"1174231", "throughput":"12288", "latency":"{2000000,1}", "size":"{16383,1}"}
{"t":"1604162845", "op":"write", "device":"sdc", "error":"0", "count":"1", "avgLatency":"1188452", "throughput":"12288", "latency":"{2000000,1}", "size":"{16383,1}"}
{"t":"1604162845", "op":"write", "device":"sdd", "error":"0", "count":"2", "avgLatency":"1083238", "throughput":"24576", "latency":"{1000000,1},{2000000,1}", "size":"{16383,2}"}
{"t":"1604162845", "op":"write", "device":"sdb", "error":"0", "count":"30", "avgLatency":"1160701", "throughput":"183808", "latency":"{600000,2},{700000,2},{800000,5},{900000,4},{1000000,7},{2000000,7},{3000000,1},{4000000,2}", "size":"{1023,5},{2047,9},{4095,3},{8191,5},{16383,4},{32767,3},{65535,1}"}
{"t":"1604162845", "op":"write", "device":"sdc", "error":"0", "count":"31", "avgLatency":"1010402", "throughput":"196096", "latency":"{600000,2},{700000,5},{800000,5},{900000,7},{1000000,4},{2000000,7},{5000000,1}", "size":"{1023,5},{2047,9},{4095,3},{8191,5},{16383,5},{32767,3},{65535,1}"}
{"t":"1604162845", "op":"write", "device":"sdd", "error":"0", "count":"32", "avgLatency":"1155545", "throughput":"145920", "latency":"{700000,3},{800000,8},{900000,8},{1000000,4},{2000000,6},{3000000,1},{4000000,2}", "size":"{1023,6},{2047,11},{4095,3},{8191,6},{16383,3},{32767,3}"}
{"t":"1604162846", "op":"write", "device":"sdb", "error":"0", "count":"2", "avgLatency":"1282255", "throughput":"32768", "latency":"{1000000,1},{2000000,1}", "size":"{16383,1},{32767,1}"}
{"t":"1604162846", "op":"write", "device":"sdc", "error":"0", "count":"1", "avgLatency":"1055364", "throughput":"12288", "latency":"{2000000,1}", "size":"{16383,1}"}
{"t":"1604162846", "op":"write", "device":"sdd", "error":"0", "count":"1", "avgLatency":"987049", "throughput":"12288", "latency":"{1000000,1}", "size":"{16383,1}"}
^Csudo ./stbtrace.py iscsi
^Csudo ./stbtrace.py nfs
^Csudo ./stbtrace.py vfs
^Csudo ./stbtrace.py zio
{"t":"1604162854", "op":"write", "count":"5", "avgLatency":"1074423", "throughput":"61440", "latency":"{900000,1},{1000000,1},{2000000,3}", "size":"{16383,5}"}
{"t":"1604162855", "op":"write", "count":"1", "avgLatency":"1366205", "throughput":"20480", "latency":"{2000000,1}", "size":"{32767,1}"}
{"t":"1604162855", "op":"write", "count":"4", "avgLatency":"1682554", "throughput":"49152", "latency":"{900000,1},{2000000,2},{4000000,1}", "size":"{16383,4}"}
{"t":"1604162856", "op":"write", "count":"118", "avgLatency":"1316471", "throughput":"499200", "latency":"{600000,2},{700000,27},{800000,25},{900000,13},{1000000,5},{2000000,25},{3000000,11},{4000000,4},{5000000,3},{6000000,3}", "size":"{1023,21},{2047,36},{4095,19},{8191,27},{16383,7},{32767,6},{65535,2}"}
^Csudo ./stbtrace.py zpl
{"t":"1604162857", "op":"write", "sync":"0", "cached":"-1", "count":"6", "avgLatency":"34453", "throughput":"57344", "latency":"{30000,2},{40000,2},{50000,2}", "size":"{16383,5},{32767,1}"}
{"t":"1604162858", "op":"write", "sync":"0", "cached":"-1", "count":"8", "avgLatency":"35807", "throughput":"49576", "latency":"{10000,1},{30000,1},{40000,3},{50000,1},{60000,2}", "size":"{127,2},{255,1},{16383,4},{32767,1}"}