Compilation failures due to fentry issue #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebroy
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
@brad-lewis can you also follow up on adding test automation to cover these? The stbtrace ones can be easily covered by extending existing analytics blackbox tests. The playbook scripts lack test automation, so we can maybe file a github issue here to track that.
prakashsurya
approved these changes
Jan 31, 2020
don-brady
pushed a commit
to don-brady/performance-diagnostics
that referenced
this pull request
May 14, 2020
don-brady
pushed a commit
to don-brady/performance-diagnostics
that referenced
this pull request
May 14, 2020
don-brady
pushed a commit
that referenced
this pull request
May 14, 2020
…#47) Co-authored-by: Brad Lewis <brad.lewis@delphix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes in ftrace.h the bcc C code fails to compile for scripts including zfs headers.
For example:
$ sudo ./estat.py zil
In file included from /virtual/main.c:8:
In file included from /usr/src/zfs-5.3.0-26-generic/include/sys/zfs_vfsops.h:29:
In file included from /usr/src/zfs-5.3.0-26-generic/include/sys/dataset_kstats.h:30:
In file included from /usr/src/zfs-5.3.0-26-generic/include/sys/aggsum.h:22:
In file included from /usr/src/zfs-5.3.0-26-generic/include/sys/zfs_context.h:57:
In file included from /usr/src/zfs-5.3.0-26-generic/include/spl/sys/sunddi.h:32:
In file included from /usr/src/zfs-5.3.0-26-generic/include/spl/sys/vnode.h:29:
In file included from include/linux/syscalls.h:85:
In file included from include/trace/syscall.h:7:
In file included from include/linux/trace_events.h:10:
In file included from include/linux/perf_event.h:49:
In file included from include/linux/ftrace.h:21:
./arch/x86/include/asm/ftrace.h:7:3: error: Compiler does not support fentry?
error Compiler does not support fentry?
^
1 error generated.