Fix backend io collector post 5.x kernel upgrade #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-lewis
approved these changes
Dec 5, 2019
|
Will rework this to handle both 4.x and 5.x kernels. |
sebroy
requested changes
Dec 5, 2019
|
Re-worked PR to handle both 4.x and 5.x kernels. Verified both @brad-lewis, @sebroy please re-review. |
sebroy
approved these changes
Dec 5, 2019
prashks
added a commit
to prashks/performance-diagnostics
that referenced
this pull request
Dec 5, 2019
* Fix backend io collector post 5.x kernel upgrade * Check for kprobe existence before attaching * Fix lint 1
sebroy
pushed a commit
that referenced
this pull request
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to linux kernel 5.x breaks the backend IO collector, using
estatorstbtracefails withFailed to attach BPF program disk_io_start to kprobe blk_start_requestThis is a quick fix, verified on latest trunk VM using 5.x kernel.