Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

estat zpl and zvol scripts not compiling #53

Closed
brad-lewis opened this issue Feb 1, 2021 · 0 comments · Fixed by #55
Closed

estat zpl and zvol scripts not compiling #53

brad-lewis opened this issue Feb 1, 2021 · 0 comments · Fixed by #55

Comments

@brad-lewis
Copy link
Contributor

On 6.1.0.0 estat zpl and zvol scripts are failing to compile:

$ sudo estat zvol -m 5
In file included from /virtual/main.c:63:
/usr/src/zfs-5.4.0-64-dx2021012602-7a44e1b99-generic/include/sys/zvol_impl.h:53:2: error: unknown type name 'dataset_kstats_t'
dataset_kstats_t zv_kstat; /* zvol kstats */
^
/virtual/main.c:168:3: warning: 'memcpy' will always overflow; destination buffer has size 5, but size argument is 6 [-Wfortify-source]
__builtin_memcpy(&axis, "sync", WRITE_LENGTH);
^
/virtual/main.c:171:3: warning: 'memcpy' will always overflow; destination buffer has size 5, but size argument is 6 [-Wfortify-source]
__builtin_memcpy(&axis, "async", WRITE_LENGTH);
^
2 warnings and 1 error generated.
Traceback (most recent call last):
File "/usr/bin/estat", line 402, in
b = BPF(text=bpf_text, cflags=cflags, debug=debug_level)
File "/usr/lib/python3/dist-packages/bcc/init.py", line 364, in init
raise Exception("Failed to compile BPF module %s" % (src_file or ""))
Exception: Failed to compile BPF module

$ sudo estat zpl -m 5
/virtual/main.c:94:57: error: unknown type name 'uio_t'
zfs_read_write_entry(io_info_t *info, struct inode *ip, uio_t *uio, int flags)
^
/virtual/main.c:120:55: error: unknown type name 'uio_t'
zfs_read_entry(struct pt_regs *ctx, struct inode *ip, uio_t *uio, int flags)
^
/virtual/main.c:129:56: error: unknown type name 'uio_t'
zfs_write_entry(struct pt_regs *ctx, struct inode *ip, uio_t *uio, int flags)
^
/virtual/main.c:139:60: error: unknown type name 'uio_t'
zfs_read_write_exit(struct pt_regs *ctx, struct inode *ip, uio_t *uio)
^
4 errors generated.
Traceback (most recent call last):
File "/usr/bin/estat", line 402, in
b = BPF(text=bpf_text, cflags=cflags, debug=debug_level)
File "/usr/lib/python3/dist-packages/bcc/init.py", line 364, in init
raise Exception("Failed to compile BPF module %s" % (src_file or ""))
Exception: Failed to compile BPF module

brad-lewis added a commit to brad-lewis/performance-diagnostics that referenced this issue Feb 1, 2021
brad-lewis added a commit that referenced this issue Feb 3, 2021
brad-lewis added a commit to brad-lewis/performance-diagnostics that referenced this issue Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant