Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commas in the output of keys in estat #10

Closed
sebroy opened this issue Nov 19, 2019 · 0 comments
Closed

commas in the output of keys in estat #10

sebroy opened this issue Nov 19, 2019 · 0 comments

Comments

@sebroy
Copy link
Contributor

sebroy commented Nov 19, 2019 

delphix@guild:~$ sudo estat backend-io 1
11/19/19 - 18:57:40 UTC

 Tracing enabled... Hit Ctrl-C to end.
   microseconds                                                  read ,
value range                 count ------------- Distribution -------------
[100, 200)                      1 |@

   microseconds                                                 write ,
value range                 count ------------- Distribution -------------
[500, 600)                      4 |@@@@@@@@@@@@@@@@@@
[700, 800)                      2 |@@@@@@
[800, 900)                      1 |@

                                       iops(/s)  avg latency(us)       stddev(us)  throughput(k/s)
 read ,                                       1              150                0                0
 write ,                                      7              638            12865               92


                                       iops(/s)  throughput(k/s)
 total                                        8               92

There are commas after read and write both at the top of each histogram, and at the start of each summary line.
brad-lewis added a commit to brad-lewis/performance-diagnostics that referenced this issue Dec 19, 2019
@brad-lewis
commas in the output of keys in estat
13d6777 
estat: too many arguments output when there are too few
estat: remove mandatory final positional duration argument

closes delphix#10, closes delphix#14, and closes delphix#16
brad-lewis added a commit to brad-lewis/performance-diagnostics that referenced this issue Jan 10, 2020
@brad-lewis
commas in the output of keys in estat
25ee8ed 
estat: too many arguments output when there are too few
estat: remove mandatory final positional duration argument

closes delphix#10, closes delphix#14, and closes delphix#16
@sebroy sebroy closed this as completed in a0fc93c Jan 10, 2020
don-brady pushed a commit to don-brady/performance-diagnostics that referenced this issue Mar 27, 2020
@brad-lewis
commas in the output of keys in estat (delphix#22)
95e651e 
estat: too many arguments output when there are too few
estat: remove mandatory final positional duration argument

closes delphix#10, closes delphix#14, and closes delphix#16

Backport to 6.0.2.0
@don-brady don-brady mentioned this issue Mar 27, 2020
Merged
don-brady pushed a commit to don-brady/performance-diagnostics that referenced this issue May 11, 2020
commas in the output of keys in estat [Backport of delphix#22 to 6.0.…
94e1690 
…3.0]

estat: remove mandatory final positional duration argument
estat: too many arguments output when there are too few

closes delphix#10, closes delphix#14, and closes delphix#16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebroy