-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NSRPARMA-52] [feature] Ephemeron MightyEBIC support #2974
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not yet completely tested on the hardware, and device software still have non-functional behaviour.
d277566
to
f8ffddf
Compare
tmoerkerken
requested changes
Dec 17, 2024
tepals
requested changes
Jan 10, 2025
install/linux/usr/share/odemis/sim/sparc2-ephemeron-sim.odm.yaml
Outdated
Show resolved
Hide resolved
install/linux/usr/share/odemis/sim/sparc2-ephemeron-sim.odm.yaml
Outdated
Show resolved
Hide resolved
install/linux/usr/share/odemis/sim/sparc2-ephemeron-sim.odm.yaml
Outdated
Show resolved
Hide resolved
Don't connect/disconnect after every call. Add more type annotations and docstrings Handle the state changes during acquisition properly (and adjust the simulator to behave as the hardware is supposed to behave) Fix the shape of the DataArray. Compute both Samples per pixel and oversampling based on the dwell time, effciently. Log more metadata.
Connect dwell time of detector (the Ephemeron EBIC) and the scanner (ie, the e-beam scan board). Adjust timeout in acquisition, as the EBIC can take a long time (compared to short acquisitions) to return the data (~1s).
f8ffddf
to
a0c80cb
Compare
a0c80cb
to
f1c14bb
Compare
tepals
approved these changes
Feb 17, 2025
tmoerkerken
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special driver for the digital connection with the Ephemeron MightyEBIC detector. It requires to be specifically connected from the "pixel" trigger of the semnidaq driver to the EBIC controller via a TTL signal. Then, this driver allows to setup the (remote) control computer of the MightyEBIC specifically for a given acquisition, and receive the EBIC signal digitally.
In addition to the driver, it also introduces a few tweaks to the SPARC synchronized acquisition in order to handle the slightly unusual behaviour of this detector.