[refactor] Clean up xt_client docstrings to make them match with the … #2677
Conversation
src/odemis/driver/xt_client.py
Outdated
| update.show() | ||
| else: | ||
| logging.warning("{} is a bad file in {} not transferring latest package.".format(ret, package.path)) | ||
| except Exception as err: | ||
| logging.exception(err) | ||
|
|
||
| def list_available_channels(self): | ||
| def list_available_channels(self) -> dict: |
There was a problem hiding this comment.
Can you indicate the type of the key & value?
There was a problem hiding this comment.
I just noticed that this function is not there anymore in the xtadapter, so I will completely remove it. Should I do that as a separate commit in this PR or in a new one?
There was a problem hiding this comment.
There are actually no user? If so, the removal can be very simple, and just as a separate commit of this PR. Otherwise, just keep it for later, as a separate PR.
There was a problem hiding this comment.
There is no actual user, I'll then do it as a separate commit on this PR.
|
BTW, to test your typing, you can install Then, run the test cases. |
57fd016 to
c2412c6
Compare
…current guidelines Additionally make use of typing and remove unused returns.
The function list_available_channels was removed from the xtadapter, but was not removed here. It is not called anywhere, therefore we can safely remove it here.
c2412c6 to
0e85c3d
Compare
…current guidelines
Additionally make use of typing and remove unused returns.