[fix] Only check if the stage is in FM Imaging mode when moving to a … #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature in Meteor In Enzel and Mimas the stage is allowed to move to a feature in SEM imaging mode. Fix as part of the Odemis 3.4 release.
K4rishma
approved these changes
Feb 7, 2024
FCanberk
approved these changes
Feb 7, 2024
Comment on lines
+97
to
+100
| # TODO: @patrick remove this once SEM move is supported | ||
| if current_label != FM_IMAGING and self._main_data_model.microscope.role == "meteor": | ||
| logging.info(f"Currently under {POSITION_NAMES[current_label]}, " | ||
| f"moving to feature position is not yet supported.") |
There was a problem hiding this comment.
@patrickcleeve2 wanted to tag you to ensure that you have a notification about it and you are indeed aware of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…feature in Meteor
In Enzel and Mimas the stage is allowed to move to a feature in SEM imaging mode.
Fix as part of the Odemis 3.4 release.