Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] new semnidaq driver: control a SEM via the NI-DAQ API #2655

Conversation

pieleric
Copy link
Member

Depends on the "nidaqmx-python" Python wrapper for using the NI-DAQmx API.
For now tested only on a NI PCIe-6361... and also known to not work
yet on older devices like the PCIe-6251.

It supports all features needed for the SECOM and SPARC, with the
exception of the counter detector. Tested succesfully on a real SEM.

It is possible to test it on a computer without an actual card by using
the NI-DAQmx with a simulated DAQ card. Instructions are in the top
comment of semnidaq.py .

Also introduces two microscope files: one to use a real DAQ board, only,
and one to simulate a SPARC using a simulated NI DAQ board.A

@pieleric pieleric requested review from FCanberk and tepals January 31, 2024 10:31
@pieleric pieleric force-pushed the feature-new-semnidaq-driver-control-a-sem-via-the-ni-daq-api branch 3 times, most recently from 8cac6cc to 3064d94 Compare February 2, 2024 17:28
Copy link
Contributor

@FCanberk FCanberk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am doing the new linter's job for this PR:

please don't forget to add the empty new lines at the end of files 😁

Copy link
Contributor

@tepals tepals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to look into everything as much as possible, but I'm sure I missed something. Let me know if there is a specific part or function that you want me to look into in more detail.

@pieleric pieleric force-pushed the feature-new-semnidaq-driver-control-a-sem-via-the-ni-daq-api branch from 3064d94 to aac7517 Compare February 20, 2024 14:26
@pieleric pieleric requested a review from tepals February 20, 2024 14:29
Allows to round a value to multiple of any given number, while managing
floating point error.
Depends on the "nidaqmx-python" Python wrapper for using the NI-DAQmx API.
For now tested only on a NI PCIe-6361... and also known to not work
yet on older devices like the PCIe-6251.

It supports all features needed for the SECOM and SPARC, with the
exception of the counter detector. Tested succesfully on a real SEM.

It is possible to test it on a computer without an actual card by using
the NI-DAQmx with a simulated DAQ card. Instructions are in the top
comment of semnidaq.py .

Also introduces two microscope files: one to use a real DAQ board, only,
and one to simulate a SPARC using a simulated NI DAQ board.A
@pieleric pieleric merged commit 48fc733 into delmic:master Feb 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants