[TRCL-55] add folding of the streams #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieleric
requested changes
Dec 20, 2023
K4rishma
reviewed
Dec 28, 2023
a207baa to
02ba044
Compare
pieleric
requested changes
Jan 8, 2024
02ba044 to
5cf6655
Compare
K4rishma
approved these changes
Jan 11, 2024
pieleric
requested changes
Jan 11, 2024
…ll time, repetition, roi values are the same and the detectors are different. Add a info text on the GUI as well that lets the user know the acqusitions will be folded(merged)
5cf6655 to
de1a9e5
Compare
pieleric
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add folding of the CL intensity and EBIC streams for SPARC if the dwell time, repetition, roi values are the same and the detectors are different
Add an info text on the GUI as well that lets the user know the acquisitions will be folded(merged)
Add test cases with different dwell time, repetition, roi combinations for the folding
Lastly, fix small PEP-8 incompatibilities