Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding UTs for snapshot module #147

Merged
merged 10 commits into from
Feb 3, 2025
Merged

Conversation

trisha-dell
Copy link
Collaborator

Description

Adding UTs for snapshot module to improve coverage.

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test
  • Functional Test

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 99.71182% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.41%. Comparing base (ed16885) to head (d92decc).

Files with missing lines Patch % Lines
plugins/modules/snapshot.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   86.09%   86.41%   +0.32%     
==========================================
  Files         139      145       +6     
  Lines       15357    16067     +710     
  Branches     2232     2297      +65     
==========================================
+ Hits        13221    13884     +663     
- Misses       1493     1517      +24     
- Partials      643      666      +23     
Flag Coverage Δ
units 86.41% <99.71%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sachin-apa sachin-apa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as the Integration tests are passing for the modules on the changes done

@sachin-apa sachin-apa merged commit 7c09d52 into dell:main Feb 3, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants