Skip to content

Commit

Permalink
Go back to a full require for requiring the extension (#635)
Browse files Browse the repository at this point in the history
This fixes byebug usage in Fedora. Fedora's rubygems uses a switch to
prevent compiled extensions from being installed into each gem's lib/
directory (`Gem.install_extension_in_lib = false`). So byebug doesn't
properly work there.

Going back to a require fixes the issue.
  • Loading branch information
deivid-rodriguez authored Jan 23, 2020
1 parent 82ce64c commit 3ec2c6a
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 1 deletion.
34 changes: 34 additions & 0 deletions .github/workflows/fedora.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
---

name: fedora

on:
pull_request:

push:
branches:
- master

jobs:
test:
container: fedora:31

runs-on: ubuntu-18.04

steps:
- uses: actions/checkout@master

- name: Install OS dependencies
run: dnf install -y ruby ruby-devel make gcc redhat-rpm-config

- name: Install bundler
run: gem install bundler:2.1.4

- name: Install development dependencies
run: bundle install

- name: Install byebug
run: bin/rake install

- name: Run byebug
run: byebug -h
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## [Unreleased]

### Fixed

* [#635](https://github.com/deivid-rodriguez/byebug/pull/635): usage on Fedora 31 or any other `byebug` installation performed by a `rubygems` copy customized by setting `Gem.install_extension_in_lib` to false.

## [11.1.0] - 2020-01-20

### Added
Expand Down
2 changes: 1 addition & 1 deletion lib/byebug/core.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# frozen_string_literal: true

require_relative "helpers/reflection"
require_relative "byebug"
require "byebug/byebug"
require_relative "context"
require_relative "breakpoint"
require_relative "interface"
Expand Down

0 comments on commit 3ec2c6a

Please sign in to comment.