This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
Drop WAGI.NET/ReverseProxy support #306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
The scheduler's getting a cleanup. WAGI.NET (and eventually WAGI) support is being dropped in favour of a new scheduler (and runtime) interface that can handle multiple triggers (see #299). Reverse proxy support is something that should be provided by the scheduler rather than through Hippo directly. Or at the very least, a reverse proxy should read events coming from the scheduler to update its own configuration. This results in a much cleaner, concise code base. Hippo's primary responsibility is with packaging and scheduling tasks onto the scheduler. Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
aed829d to
22707e5
Compare
|
Something we could do in the future is pull YARP out into a separate project which sits next to Hippo: Where Core contains logic pertaining to the scheduler which both the API and the ReverseProxy projects can use to synchronize state. |
This was
linked to
issues
Dec 2, 2021
Closed
|
closing in favour of #309 and another follow-up PR that will pull out the ReverseProxy into its own project. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scheduler's getting a cleanup. WAGI.NET (and eventually WAGI) support is
being dropped in favour of a new scheduler (and runtime) interface that can
handle multiple trigger types (see #299).
Reverse proxy support is something that should be provided by the
scheduler rather than through Hippo directly. Or at the very least, a reverse
proxy should read events coming from the scheduler to update its own
configuration.
This results in a much cleaner, concise code base. Hippo's primary
responsibility is with packaging and scheduling tasks onto the scheduler.
Builds on top of #301 which should be merged first.