Accept prerelease syntax in Create Channel API (#147)

deislabs · Jul 14, 2021 · f323a95 · f323a95
1 parent 884fec2
commit f323a95
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/Hippo/Messages/CreateChannelRequest.cs b/Hippo/Messages/CreateChannelRequest.cs
@@ -3,6 +3,7 @@
 using System.ComponentModel.DataAnnotations;
 using Hippo.Logging;
 using Hippo.Models;
+using Hippo.Rules;
 
 namespace Hippo.Messages
 {
@@ -65,10 +66,11 @@ public IEnumerable<ValidationResult> Validate(ValidationContext validationContex
                 }
 
 
-                if (!SemVer.Range.TryParse(RevisionRange, out _))
+                var ruleError = RevisionRangeRule.Validate(RevisionRange);
+                if (ruleError != null)
                 {
                     yield return new ValidationResult(
-                        $"Revision Range does not comply with Semantic Versioning version number range rules",
+                        $"Revision range is not valid rule syntax: {ruleError.Message}",
                         new[] { nameof(RevisionRange) });
                 }
 

diff --git a/Hippo/Rules/RevisionRangeRule.cs b/Hippo/Rules/RevisionRangeRule.cs
@@ -25,6 +25,19 @@ public static RevisionRangeRule Parse(string? rule)
             return new NpmRevisionRangeRule(rule);
         }
 
+        public static Exception? Validate(string? rule)
+        {
+            try
+            {
+                Parse(rule);
+                return null;
+            }
+            catch (Exception e)
+            {
+                return e;
+            }
+        }
+
         public abstract Revision? Match(ICollection<Revision> candidates);
 
         private class NpmRevisionRangeRule : RevisionRangeRule