Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase coverage on util functions to ensure work is thoroughly tested #1591

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

cmwylie19
Copy link
Collaborator

@cmwylie19 cmwylie19 commented Dec 16, 2024

Description

Increase test coverage in utils for createDir and write to ensure our logic is covered

Related Issue

Fixes #1590

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@cmwylie19 cmwylie19 requested a review from a team as a code owner December 16, 2024 22:06
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.30%. Comparing base (2b2d927) to head (f2828ab).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1591      +/-   ##
==========================================
+ Coverage   80.84%   81.30%   +0.46%     
==========================================
  Files          42       42              
  Lines        1952     1952              
  Branches      451      451              
==========================================
+ Hits         1578     1587       +9     
+ Misses        372      363       -9     
  Partials        2        2              

see 1 file with indirect coverage changes

@cmwylie19 cmwylie19 changed the title chore: increase coverage on a couple of functions chore: increase coverage on util functions to ensure work is thoroughly tested Dec 16, 2024
Copy link
Collaborator

@samayer12 samayer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coverage++

@samayer12 samayer12 added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit cd255d5 Dec 16, 2024
50 checks passed
@samayer12 samayer12 deleted the 1590 branch December 16, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

increase coverage in utils
2 participants