This repository has been archived by the owner on Feb 15, 2025. It is now read-only.
test(e2e): move openai client to fixture #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for leapfrogai-docs canceled.
|
jalling97
approved these changes
Aug 27, 2024
gphorvath
approved these changes
Aug 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test discovery in IDE can fail due to code that runs on dependency resolution. This code makes web requests to retrieve access tokens, but can fail due to a number of reasons. As a result, test discovery will fail and the IDE will not show correct information about your test functions, and will have many errors in the test Output log, making debugging other issues more difficult.
CHANGES
This PR moves OpenAI client into a fixture that will only run once for each module. This will prevent the IDE from throwing errors on discovery.