This repository has been archived by the owner on Feb 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
feat(api)!: initial integration of registry1 api flavor #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for leapfrogai-docs canceled.
|
Depends on documentation updates from #902, and then one more update on top of that documentation. |
…pi-registry1-flavor
CollectiveUnicorn
previously approved these changes
Aug 31, 2024
gphorvath
reviewed
Sep 3, 2024
gphorvath
previously approved these changes
Sep 3, 2024
Pending @YrrepNoj approval too! Thanks @gphorvath and @CollectiveUnicorn |
7a019e0
CollectiveUnicorn
previously approved these changes
Sep 3, 2024
gphorvath
previously approved these changes
Sep 3, 2024
YrrepNoj
suggested changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change request and one pondering on if we should consider this PR a 'breaking' change.
8a41f46
YrrepNoj
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the updates.
CollectiveUnicorn
approved these changes
Sep 3, 2024
gphorvath
approved these changes
Sep 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OVERVIEW
Adds the Registry1 flavor of the LeapfrogAI API to the developer workflow and increases Helm chart and Dockerfile standard (foreshadowing upcoming Helm and Dockerfile linting PR).
Once all other
registry1
flavored images are published to IronBank, thee2e-registry1-weekly.yaml
will need to have access to auds-bundle.yaml
that points to packages created using theregistry1.dso.mil
container registry. For now, as each component comes online, we can use theyq
commands to temporarily modify each one within the workflow:BREAKING CHANGES
leapfrogai-api
instead ofapi
, following the convention of using the Helm chart name for template helpersIMAGE_VERSION
instead ofLEAPFROGAI_IMAGE_VERSION
, to align the build process with all other components/packagesCHANGES
FLAVOR
flag to the Makefile, defaulting toupstream
registry1
Zarf package flavoring for the API