Skip to content
This repository has been archived by the owner on Feb 15, 2025. It is now read-only.

feat(ui): Flowbite header and sidebar #813

Merged
merged 28 commits into from
Jul 25, 2024
Merged

Conversation

andrewrisse
Copy link
Contributor

@andrewrisse andrewrisse commented Jul 22, 2024

First PR for converting to Flowbite.

  • Adds Flowbite and TailwindCSS
  • Refactors the header, sidebar, settings/user side drawers, and toast store
  • Removes SASS Carbon preprocessor styling injects (ex implication: gap: layout.$spacing-03; becomes gap: 0.5rem;)
  • Fixes playwright tests so that they run locally again (broken with Playwright CI story)
  • Updates tests so all unit and E2E tests are still passing despite mix of carbon and flowbite components

Deployed on LF-04
LeapfrogAI - Chat - 22 July 2024 - Watch Video

@andrewrisse andrewrisse added the enhancement New feature or request label Jul 22, 2024
@andrewrisse andrewrisse self-assigned this Jul 22, 2024
@BillyFigueroa
Copy link

It looks like a good amount of the changes were un-doing a lot of the scss variables provided by carbon. I would likely recommend created some sort of js file you can export those types of values or doing something in scss/ postcss where you are creating your own utility classes, maybe even with the same name, to replace with and remove the problem of repetition as well as when you might need to make a chance in the future, you change it in one place

* add k3d gpu Dockerfile and nvidia daemonset
* add k3d gpu image build/release to release pipeline
* add make commands to streamline standing up k3d-gpu uds cluster
@andrewrisse andrewrisse marked this pull request as ready for review July 23, 2024 18:38
@andrewrisse andrewrisse requested a review from a team as a code owner July 23, 2024 18:38
andrewrisse and others added 2 commits July 23, 2024 12:53
* update packages and refactor to use new supabase patterns

* Fix many typescript errors

* fix playwright token fetching
@andrewrisse
Copy link
Contributor Author

It looks like a good amount of the changes were un-doing a lot of the scss variables provided by carbon. I would likely recommend created some sort of js file you can export those types of values or doing something in scss/ postcss where you are creating your own utility classes, maybe even with the same name, to replace with and remove the problem of repetition as well as when you might need to make a chance in the future, you change it in one place

Very valid point, but those changes are temporary (like changing tomorrow) as we move to flowbite. They just let the app compile while we remove the carbon sass precompile stuff.

@BillyFigueroa
Copy link

It looks like a good amount of the changes were un-doing a lot of the scss variables provided by carbon. I would likely recommend created some sort of js file you can export those types of values or doing something in scss/ postcss where you are creating your own utility classes, maybe even with the same name, to replace with and remove the problem of repetition as well as when you might need to make a chance in the future, you change it in one place

Very valid point, but those changes are temporary (like changing tomorrow) as we move to flowbite. They just let the app compile while we remove the carbon sass precompile stuff.

Copy 🙌🏽

gphorvath and others added 4 commits July 24, 2024 20:11
* (breaking) updating api key endpoint names
* updates UI with the new api key endpoint conventions
* moving leapfrogai models endpoint into leapfrogai namespace
* changes rag endpoint to leapfrogai/vector_stores/search
* temporarily disables the playwright tests that keep failing in the e2e pipeline

---------

Co-authored-by: Andrew Risse <andrewrisse@gmail.com>
* fix playwright login without keycloak
---------

Co-authored-by: John Alling <john.alling@defenseunicorns.com>
@andrewrisse andrewrisse merged commit 25d69d0 into flowbite-integration Jul 25, 2024
8 checks passed
@andrewrisse andrewrisse deleted the flowbite branch July 25, 2024 22:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants