Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to the README #7

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Add context to the README #7

merged 5 commits into from
Jun 11, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented May 28, 2024

Related Issues

  • fixes n/a

Proposed Changes:

Add context to the readme file. PREVIEW

How did you test it?

Notes for the reviewer

Checklist

@masci masci requested review from a team as code owners May 28, 2024 08:30
@masci masci requested review from dfokina, silvanocerza and shadeMe and removed request for a team and silvanocerza May 28, 2024 08:30
Copy link
Contributor

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few comments and suggestions.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left my unsolicited comments :)

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@masci masci requested a review from shadeMe June 11, 2024 07:27
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged a couple of suggestions from the previous review that got missed. LGTM otherwise.

@masci masci merged commit 69013a9 into main Jun 11, 2024
@masci masci deleted the massi/readme branch June 11, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants