chore: remove everything related to ChatMessage and Tool
#169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Pull Request Test Coverage Report for Build 12833107261Details
💛 - Coveralls |
anakin87
commented
Jan 17, 2025
| @@ -53,18 +52,11 @@ dependencies = [ | |||
|
|
|||
| [tool.hatch.envs.test] | |||
| extra-dependencies = [ | |||
| "transformers<4.46.0", # https://github.com/huggingface/transformers/issues/34370 | |||
| "transformers>=4.47.0, <4.48.0", # https://github.com/huggingface/transformers/issues/35639 | |||
| ], | ||
| "tools_strict": True, | ||
| }, | ||
| } | ||
|
|
||
| def test_to_dict_with_lambda_streaming_callback(self, monkeypatch): |
There was a problem hiding this comment.
we no longer allow serialization of lambdas
| @@ -733,7 +733,7 @@ def run(self, prompt_source: List[ChatMessage]): | |||
| class MessageMerger: | |||
| @component.output_types(merged_message=str) | |||
| def run(self, messages: List[ChatMessage], metadata: dict = None): | |||
| return {"merged_message": "\n".join(t.content for t in messages)} | |||
| return {"merged_message": "\n".join(t.text for t in messages)} | |||
| @@ -1,276 +0,0 @@ | |||
| # SPDX-FileCopyrightText: 2022-present deepset GmbH <info@deepset.ai> | |||
There was a problem hiding this comment.
this was only implemented to support the new ChatMessage (now integrated in Haystack)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
ChatMessageto Haystack haystack#8583 andProposed Changes:
ChatMessageandToolwork has been migrated to Haystack and core-integrations, remove everything related to this experimentHow did you test it?
CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.