Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better exceptions handling during pipeline deployment #48

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

mpangrazzi
Copy link
Contributor

@mpangrazzi mpangrazzi commented Dec 17, 2024

This fixes #47.

I've added the bare minimum to handle any unhandled exceptions during pipeline deployment (now it returns a HTTP 500 with error details).

I've also added tests for pipeline registry, which was uncovered.

Of course, this is the bare minimum to avoid to throw and broke during pipeline deployment. I plan to add further minor improvements such as:

  • use APIRouter to better organize route handlers
  • extend better error handling on other routes
  • type fixes

@mpangrazzi mpangrazzi marked this pull request as ready for review December 17, 2024 08:00
@mpangrazzi mpangrazzi requested a review from anakin87 December 17, 2024 08:00
@mpangrazzi mpangrazzi changed the title Better exceptions handling Better exceptions handling during pipeline deployment Dec 17, 2024
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I would suggest prioritizing the work on the CI so that we can run tests on PRs.

@mpangrazzi
Copy link
Contributor Author

@anakin87 Thanks! Yeah, wanted to nailed this before, next step will be CI.

@mpangrazzi mpangrazzi merged commit ad6837b into main Dec 17, 2024
@mpangrazzi mpangrazzi deleted the better-exceptions-handling branch December 17, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONDecodeError in Client and Pydantic Schema Error on Server during Pipeline Deployment
2 participants