-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft deployment guidelines #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good to me already. I just made four tiny suggestions and then what we have so far is ready to be merged from my side. Let's wait for Stefano's review on Monday.
Co-authored-by: Julian Risch <julianrisch@gmx.de>
Co-authored-by: Julian Risch <julianrisch@gmx.de>
Co-authored-by: Julian Risch <julianrisch@gmx.de>
Co-authored-by: Julian Risch <julianrisch@gmx.de>
@julian-risch thanks! Yes, let's wait for @anakin87 review. Probably it could worth to add an end-to-end example or tutorial (build a simple pipeline, serialise it to YAML, run Hayhooks and run it), WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the guidelines.
They should be understandable for someone familiar with these topics and provide a good introduction to others.
- We should probably link them (or copy them?) in our docs: https://docs.haystack.deepset.ai/docs/hayhooks; https://docs.haystack.deepset.ai/docs/deployment
- An end-to-end example would be helpful
- Keep in mind that there is an (unmaintained) demo based on Hayhooks: https://github.com/deepset-ai/haystack-demos/tree/main/qdrant_indexing
@anakin87 ah, didn't know about that existing demo. I think it would be good to have a similar one here, e.g. on an |
@julian-risch @anakin87 I'll merge this and add the examples in a separate PR |
The purpose of this document is simply to make people more aware of how pipelines can be deployed and called on Hayhooks in different environment (single vs multiple workers).
TODO:
end-to-end examples (I/O bound vs CPU bound)Update: will add it in a separate PR