Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft deployment guidelines #46

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Draft deployment guidelines #46

merged 6 commits into from
Dec 10, 2024

Conversation

mpangrazzi
Copy link
Contributor

@mpangrazzi mpangrazzi commented Dec 5, 2024

The purpose of this document is simply to make people more aware of how pipelines can be deployed and called on Hayhooks in different environment (single vs multiple workers).

TODO:

  • Basic recommendations on deployment in single vs multiple worker environments
  • end-to-end examples (I/O bound vs CPU bound) Update: will add it in a separate PR

@mpangrazzi mpangrazzi marked this pull request as ready for review December 5, 2024 13:12
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good to me already. I just made four tiny suggestions and then what we have so far is ready to be merged from my side. Let's wait for Stefano's review on Monday.

docs/deployment_guidelines.md Outdated Show resolved Hide resolved
docs/deployment_guidelines.md Outdated Show resolved Hide resolved
docs/deployment_guidelines.md Outdated Show resolved Hide resolved
docs/deployment_guidelines.md Outdated Show resolved Hide resolved
mpangrazzi and others added 4 commits December 6, 2024 15:49
Co-authored-by: Julian Risch <julianrisch@gmx.de>
Co-authored-by: Julian Risch <julianrisch@gmx.de>
Co-authored-by: Julian Risch <julianrisch@gmx.de>
Co-authored-by: Julian Risch <julianrisch@gmx.de>
@mpangrazzi
Copy link
Contributor Author

@julian-risch thanks! Yes, let's wait for @anakin87 review.

Probably it could worth to add an end-to-end example or tutorial (build a simple pipeline, serialise it to YAML, run Hayhooks and run it), WDYT?

Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the guidelines.
They should be understandable for someone familiar with these topics and provide a good introduction to others.

@mpangrazzi
Copy link
Contributor Author

@anakin87 ah, didn't know about that existing demo. I think it would be good to have a similar one here, e.g. on an examples folder or so. I can take care of it.

@julian-risch julian-risch self-requested a review December 10, 2024 13:04
@mpangrazzi
Copy link
Contributor Author

@julian-risch @anakin87 I'll merge this and add the examples in a separate PR

@mpangrazzi mpangrazzi merged commit 5739ee6 into main Dec 10, 2024
@mpangrazzi mpangrazzi deleted the deployment-guidelines branch December 10, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants