Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add retry for server disconnect #106

Merged
merged 4 commits into from
Sep 7, 2023
Merged

fix: add retry for server disconnect #106

merged 4 commits into from
Sep 7, 2023

Conversation

ArzelaAscoIi
Copy link
Member

Related Issues

  • hotfix

Proposed Changes?

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

@github-actions
Copy link

github-actions bot commented Sep 7, 2023 •
edited
Loading

Coverage report

The coverage rate went from 92.86% to 92.89% ⬆️
The branch rate is 80%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

deepset_cloud_sdk/_s3/upload.py

100% of new lines are covered (91.25% of the complete file).

@ArzelaAscoIi ArzelaAscoIi changed the title tests: add test for failing fix: add retry for server disconnect Sep 7, 2023
@ArzelaAscoIi ArzelaAscoIi merged commit e917f5f into main Sep 7, 2023
@ArzelaAscoIi ArzelaAscoIi deleted the fix/retryServerDisconnect branch September 7, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ton of ServerDisconnectedErrors against HTTPS AWS S3 REST API
2 participants
@ArzelaAscoIi @wochinge