Skip to content

Commit

Permalink
uniq_atom_name -> uniq_atom_names
Browse files Browse the repository at this point in the history
  • Loading branch information
Han Wang committed Feb 26, 2022
1 parent a6c6606 commit 898a856
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions dpdata/plugins/vasp.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import dpdata.vasp.outcar
import numpy as np
from dpdata.format import Format
from dpdata.utils import sort_atom_names, uniq_atom_name
from dpdata.utils import sort_atom_names, uniq_atom_names

@Format.register("poscar")
@Format.register("contcar")
Expand All @@ -15,7 +15,7 @@ def from_system(self, file_name, **kwargs):
with open(file_name) as fp:
lines = [line.rstrip('\n') for line in fp]
data = dpdata.vasp.poscar.to_system_data(lines)
data = uniq_atom_name(data)
data = uniq_atom_names(data)
return data

def to_system(self, data, file_name, frame_idx=0, **kwargs):
Expand Down Expand Up @@ -73,7 +73,7 @@ def from_labeled_system(self, file_name, begin=0, step=1, **kwargs):
for ii in range(data['cells'].shape[0]):
vol = np.linalg.det(np.reshape(data['cells'][ii], [3, 3]))
data['virials'][ii] *= v_pref * vol
data = uniq_atom_name(data)
data = uniq_atom_names(data)
return data


Expand Down Expand Up @@ -105,5 +105,5 @@ def from_labeled_system(self, file_name, begin=0, step=1, **kwargs):
for ii in range(data['cells'].shape[0]):
vol = np.linalg.det(np.reshape(data['cells'][ii], [3, 3]))
data['virials'][ii] *= v_pref * vol
data = uniq_atom_name(data)
data = uniq_atom_names(data)
return data
2 changes: 1 addition & 1 deletion dpdata/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def sort_atom_names(data, type_map=None):
data['atom_types'] = np.argsort(idx)[data['atom_types']]
return data

def uniq_atom_name(data):
def uniq_atom_names(data):
"""
Make the atom names uniq. For example
['O', 'H', 'O', 'H', 'O'] -> ['O', 'H']
Expand Down
4 changes: 2 additions & 2 deletions tests/test_vasp_outcar.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import unittest
from context import dpdata
from comp_sys import CompLabeledSys, IsPBC
from dpdata.utils import uniq_atom_name
from dpdata.utils import uniq_atom_names

class TestVaspOUTCAR(unittest.TestCase, CompLabeledSys, IsPBC):
def setUp (self) :
Expand Down Expand Up @@ -76,7 +76,7 @@ def test(self):
data['atom_names'] = ['O', 'H', 'O', 'H']
data['atom_types'] = np.array([0, 1, 2, 3, 3, 2, 1], dtype=int)

data = uniq_atom_name(data)
data = uniq_atom_names(data)
self.assertEqual(list(data['atom_types']),
[0, 1, 0, 1, 1, 0, 1])
self.assertEqual(list(data['atom_names']),
Expand Down

0 comments on commit 898a856

Please sign in to comment.