Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wasmvm memory management implementation #53

Merged
merged 8 commits into from
Dec 5, 2020
Merged

Wasmvm memory management implementation #53

merged 8 commits into from
Dec 5, 2020

Conversation

JoeyTeng
Copy link

#18

@JoeyTeng
feat(memory): interfaces
ef07a9c
@JoeyTeng
[document]: Memory Management
c3b8df3 
add a new global metadata field to save the end address of remainder
block
@JoeyTeng
[backend]: memory management
4564cba 
implementation of malloc/free for fast_bins
@JoeyTeng JoeyTeng added the enhancement New feature or request label Oct 31, 2020
@JoeyTeng JoeyTeng added this to the deeplang 1.0 milestone Oct 31, 2020
@JoeyTeng JoeyTeng self-assigned this Oct 31, 2020
@JoeyTeng
[backend]: memory management
ff75231 
feat: add pseudo-random number generator for vm
@JoeyTeng
[backend]: memory management
a30776c 
integrate new source files into Makefile
@JoeyTeng
[backend]: memory management
b0f3c21 
update design doc
- use pointers instead of offsets for fast bins
- add a head block for sorted-block skiplist
  - update mem_init accordingly
@JoeyTeng
[backend]: memory management
8ae9fdf 
implemented malloc and free for sorted_bins
@JoeyTeng
Copy link
Author

Implement malloc and free without any tests.

TODO:

  • Implement realloc and migrate
  • Implement pool stats
  • Test implementations
  • Adapt for 64-bit system naturally

NOTE: There are some amendments to the original design doc.

@JoeyTeng
[backend]: bug fix for memory manager implementation
6367bd0 
- Offset calculation error, as the plain pointer arithmatics are not in
  bytes;
- Refer to payload wrongly: should refer to its address, not the address
  it point to;
- Add a NULL check;
@JoeyTeng JoeyTeng marked this pull request as ready for review December 3, 2020 13:16
@JoeyTeng JoeyTeng requested a review from chinesebear December 3, 2020 13:16
@JoeyTeng
Copy link
Author

JoeyTeng commented Dec 3, 2020

Some minimal tests are done, and the bugs spotted have been fixed.

@chinesebear
Copy link
Contributor

LGTM

@chinesebear chinesebear merged commit c263e35 into wasmvm Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinesebear chinesebear Awaiting requested review from chinesebear

Assignees

@JoeyTeng JoeyTeng

Labels
enhancement New feature or request
Projects
None yet
Milestone
Deeplang 0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeyTeng @chinesebear